Rename MCPServer CRD Port Attributes for Clarity #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `port` to `proxyPort` - represents proxy runner port - Rename `targetPort` to `mcpPort` - represents MCP server port This change addresses user confusion about port semantics as discussed in issue #1452. The new names clearly indicate which port corresponds to which component: - proxyPort: Port exposed by the proxy runner in Kubernetes - mcpPort: Port that the MCP server listens on internally Updated all relevant files: - CRD types definition and generated YAML - Operator controller logic - All example and test YAML files - Keycloak deployment example 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Chris Burns <[email protected]>
jhrozek
previously approved these changes
Sep 9, 2025
|
lol, I approved before looking at the CI run 🤦🏻 |
|
I'll pull it locally and run the docs steps |
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
ChrisJBurns
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
- Coverage 47.29% 47.29% -0.01%
==========================================
Files 223 223
Lines 27681 27681
==========================================
- Hits 13092 13091 -1
- Misses 13591 13593 +2
+ Partials 998 997 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: ChrisJBurns <[email protected]>
yrobla
approved these changes
Sep 19, 2025
|
shouldn't we resurrect this PR? |
|
@jhrozek ahh yep, let me add this to the list of things to get soon ASAP. I think the only thing thats left is to just make sure we can leave the old fields in for a few versions and make them as deprecated. this is so we don't break existing setups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
porttoproxyPort- represents proxy runner porttargetPorttomcpPort- represents MCP server portThis change addresses user confusion about port semantics as discussed in issue #1452. The new names clearly indicate which port corresponds to which component:
Updated all relevant files:
🤖 Generated with Claude Code